clean up conditional compilation for now-removed TFMs#7415
Open
fowl2 wants to merge 1 commit into
Open
Conversation
dotnet-policy-service
Bot
added
the
Community
nkolev92
reviewed
May 26, 2026
Member
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
It'd be great to follow the PR template, because it actually guides you to the information we need to more effectively review the PR.
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| #if !NETSTANDARD2_1 && !NETCOREAPP3_1_OR_GREATER && !NET5_0_OR_GREATER |
Member
There was a problem hiding this comment.
We still have 1 project that targets NS2.0 (NuGet.VisualStudio.Contracts), so in case we want to enable nullability there we should keep the NS2.0 support in this file.
|
|
||
| private static void CopyTo(Stream inputStream, Stream outputStream) | ||
| { | ||
| // .NET Framework allocates an unavoidable byte[] when using |
Member
There was a problem hiding this comment.
This seems to suggest it shouldn't be removed.
This seems like a significant decision, so we either need this reverted, or explained why it's unnecessary.
Either way I would've loved to see this called out in the PR description to help the reviewer.
nkolev92
added
the
Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since NuGet now only builds for net472 and net8.0, we can remove all the .NET Standard and previous workarounds.