Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@ragingpastry
Copy link

I just came across this today and made some changes of my own to suit the needs of my organization. Hopefully this helps others.

@ragingpastry
Copy link
Author

I'm not sure I understand what you mean with #1. Copying the mattermost_webook_url would result in gitlab firing off its webhook to the wrong place would it not?

chengweiv5 added a commit to chengweiv5/mattermost-integration-gitlab that referenced this pull request Feb 29, 2016
This patch based on below PR

  NotSqrt#3

which add multiple mattermost channel support.

To add a webhook to a project, add url like below

http://<this-project-server:port>/new_event?mattermost_webhook_url=<mattermost channel webhook url>

Signed-off-by: Chengwei Yang <yangchengwei@qiyi.com>
@chengweiv5
Copy link

@ragingpastry just like #4

@ragingpastry
Copy link
Author

Excellent. Apparently I didn't have my coffee after first reading your comments. I went ahead and modified my fork last week (and it looks like we basically made the same changes except for the variable renaming).

@chengweiv5
Copy link

@ragingpastry the fact is I'm not good at English, so you didn't understand me at first. :-)

@jar3b
Copy link

jar3b commented Jul 28, 2016

Hello! One question: why do you want to be able to change the hook url for each project instead of specifying only a particular channel?
Base logic (first case):

  1. We have a running integration worker (web-server on specific port).
  2. For each gitlab project, you pass your mattermost hook url as a webhook parameter (for doing this you need to create a separate mattermost hook for each channel, right?)
    My opinion (second case):
  3. The same way, we have one running worker.
  4. But! Instead, you can create one hook in mattermost and simply specify only the channel name for a particular gitlab project.

So, if you want to specify different hook url, you can create 2 and more outgoing hooks in gitlab project (and must start 2 integration worker processes). But why if select specified channel is our target. I think in mattermost: 1 hook - 1 external app, or it's wrong?

In this PR hid a good idea, but a usage (IMO) may be little bit different: not for specifying a channel, but for ability to install one integration worker per one gitlab machine that can send data to different Mattermost instances.

silk pushed a commit to mlabs-pl/mattermost-integration-gitlab that referenced this pull request Jan 18, 2017
This patch based on below PR

  NotSqrt#3

which add multiple mattermost channel support.

To add a webhook to a project, add url like below

http://<this-project-server:port>/new_event?mattermost_webhook_url=<mattermost channel webhook url>

Signed-off-by: Chengwei Yang <yangchengwei@qiyi.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants