-
Notifications
You must be signed in to change notification settings - Fork 43
Adding support for multiple channels and perchannel githooks #3
Conversation
|
I'm not sure I understand what you mean with #1. Copying the mattermost_webook_url would result in gitlab firing off its webhook to the wrong place would it not? |
This patch based on below PR NotSqrt#3 which add multiple mattermost channel support. To add a webhook to a project, add url like below http://<this-project-server:port>/new_event?mattermost_webhook_url=<mattermost channel webhook url> Signed-off-by: Chengwei Yang <yangchengwei@qiyi.com>
|
@ragingpastry just like #4 |
|
Excellent. Apparently I didn't have my coffee after first reading your comments. I went ahead and modified my fork last week (and it looks like we basically made the same changes except for the variable renaming). |
|
@ragingpastry the fact is I'm not good at English, so you didn't understand me at first. :-) |
|
Hello! One question: why do you want to be able to change the hook url for each project instead of specifying only a particular channel?
So, if you want to specify different hook url, you can create 2 and more outgoing hooks in gitlab project (and must start 2 integration worker processes). But why if select specified channel is our target. I think in mattermost: 1 hook - 1 external app, or it's wrong? In this PR hid a good idea, but a usage (IMO) may be little bit different: not for specifying a channel, but for ability to install one integration worker per one gitlab machine that can send data to different Mattermost instances. |
This patch based on below PR NotSqrt#3 which add multiple mattermost channel support. To add a webhook to a project, add url like below http://<this-project-server:port>/new_event?mattermost_webhook_url=<mattermost channel webhook url> Signed-off-by: Chengwei Yang <yangchengwei@qiyi.com>
I just came across this today and made some changes of my own to suit the needs of my organization. Hopefully this helps others.