CFE-4623: Fixed missing directory file separator suffix by victormlg · Pull Request #263 · NorthernTechHQ/libntech

victormlg · 2026-02-16T10:50:11Z

No description provided.

mender-test-bot · 2026-02-16T10:50:17Z

There was an error running your pipeline, see logs for details.

mender-test-bot · 2026-02-16T14:23:12Z

There was an error running your pipeline, see logs for details.

mender-test-bot · 2026-02-16T15:45:54Z

There was an error running your pipeline, see logs for details.

mender-test-bot · 2026-02-17T10:18:20Z

There was an error running your pipeline, see logs for details.

mender-test-bot · 2026-02-17T10:21:01Z

There was an error running your pipeline, see logs for details.

libutils/path.c

mender-test-bot · 2026-02-17T11:37:50Z

There was an error running your pipeline, see logs for details.

mender-test-bot · 2026-02-17T12:05:45Z

There was an error running your pipeline, see logs for details.

libutils/glob_lib.c

mender-test-bot · 2026-02-17T13:15:55Z

There was an error running your pipeline, see logs for details.

larsewi

Please change to use IsDir() which follows symbolic links

mender-test-bot · 2026-02-24T10:15:25Z

There was an error running your pipeline, see logs for details.

mender-test-bot · 2026-03-16T10:08:35Z

There was an error running your pipeline, see logs for details.

libutils/file_lib.c

mender-test-bot · 2026-03-16T12:01:02Z

There was an error running your pipeline, see logs for details.

libutils/glob_lib.c

larsewi · 2026-03-16T12:14:27Z

@cf-bottom Jenkins please :)

cf-bottom · 2026-03-16T12:17:39Z

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13448/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13448/

larsewi

Tests (3 failures / +3)
./01_vars/02_functions/findfiles.cf.findfiles.cf
./01_vars/02_functions/findfiles_up.cf.findfiles_up.cf
./04_examples/outputs/check_outputs.cf.check_outputs.cf

mender-test-bot · 2026-03-25T11:00:50Z

There was an error running your pipeline, see logs for details.

mender-test-bot · 2026-03-25T11:38:36Z

There was an error running your pipeline, see logs for details.

Ticket: CFE-4623 Signed-off-by: Victor Moene <victor.moene@northern.tech>

mender-test-bot · 2026-03-25T13:06:44Z

There was an error running your pipeline, see logs for details.

victormlg · 2026-03-25T13:16:27Z

Running with fixed tests:

victormlg · 2026-03-25T15:47:03Z

One more time:

victormlg · 2026-03-26T10:47:38Z

Fixed masterfiles:

victormlg · 2026-03-30T08:00:46Z

Fixed masterfiles:

The tests passed

larsewi

Looks good 🚀 I see that the change in masterfiles caused a recursion limit to be triggered. Please investigate

victormlg · 2026-04-06T06:10:48Z

Looks good 🚀 I see that the change in masterfiles caused a recursion limit to be triggered. Please investigate

I believe this error comes from the fact that masterfiles doesn't use this PR's changes. Running the build without the masterfiles fix caused the same error

victormlg force-pushed the append_file_sep branch from d6647b5 to c409523 Compare February 16, 2026 15:45

victormlg force-pushed the append_file_sep branch from c409523 to fa6dd04 Compare February 17, 2026 10:18

victormlg force-pushed the append_file_sep branch from fa6dd04 to 8a433e0 Compare February 17, 2026 10:20

larsewi reviewed Feb 17, 2026

View reviewed changes

libutils/path.c Outdated Show resolved Hide resolved

victormlg force-pushed the append_file_sep branch from 8a433e0 to 68ea7be Compare February 17, 2026 11:37

victormlg force-pushed the append_file_sep branch from 68ea7be to 0b0be52 Compare February 17, 2026 12:05

larsewi reviewed Feb 17, 2026

View reviewed changes

libutils/glob_lib.c Outdated Show resolved Hide resolved

victormlg force-pushed the append_file_sep branch from 0b0be52 to a7a2735 Compare February 17, 2026 13:15

victormlg requested a review from larsewi February 17, 2026 15:01

larsewi requested changes Feb 17, 2026

View reviewed changes

craigcomstock previously approved these changes Feb 20, 2026

View reviewed changes

victormlg dismissed craigcomstock’s stale review via e044dd0 February 24, 2026 10:15

victormlg force-pushed the append_file_sep branch from a7a2735 to e044dd0 Compare February 24, 2026 10:15

victormlg mentioned this pull request Feb 24, 2026

Moved IsDir from core to libntech cfengine/core#6048

Closed

victormlg force-pushed the append_file_sep branch from e044dd0 to beeae02 Compare March 16, 2026 10:08

victormlg requested a review from larsewi March 16, 2026 10:25

larsewi requested changes Mar 16, 2026

View reviewed changes

libutils/file_lib.c Show resolved Hide resolved

victormlg force-pushed the append_file_sep branch from beeae02 to 45b7f65 Compare March 16, 2026 12:00

larsewi approved these changes Mar 16, 2026

View reviewed changes

libutils/glob_lib.c Outdated Show resolved Hide resolved

larsewi requested changes Mar 17, 2026

View reviewed changes

victormlg force-pushed the append_file_sep branch from 45b7f65 to af33ca2 Compare March 25, 2026 11:00

victormlg force-pushed the append_file_sep branch from af33ca2 to e2b7e52 Compare March 25, 2026 11:38

victormlg mentioned this pull request Mar 25, 2026

CFE-4623: Added trailing sep in acceptance tests cfengine/core#6061

Merged

victormlg added 2 commits March 25, 2026 14:06

Fixed missing directory file separator suffix

588c1ff

Ticket: CFE-4623 Signed-off-by: Victor Moene <victor.moene@northern.tech>

Fixed unit tests for directory separator suffix

2053487

victormlg force-pushed the append_file_sep branch from e2b7e52 to 2053487 Compare March 25, 2026 13:06

victormlg mentioned this pull request Mar 26, 2026

CFE-4623: Added file sep to directory cfengine/masterfiles#3114

Merged

victormlg requested a review from larsewi March 30, 2026 07:55

larsewi approved these changes Mar 31, 2026

View reviewed changes

victormlg requested a review from larsewi April 6, 2026 14:54

larsewi merged commit 2fa0740 into NorthernTechHQ:master Apr 7, 2026
39 checks passed

larsewi mentioned this pull request Apr 8, 2026

Revert: CFE-4623: Fixed missing directory file separator suffix #266

Closed

Conversation

victormlg commented Feb 16, 2026

Uh oh!

mender-test-bot commented Feb 16, 2026

Uh oh!

mender-test-bot commented Feb 16, 2026

Uh oh!

mender-test-bot commented Feb 16, 2026

Uh oh!

mender-test-bot commented Feb 17, 2026

Uh oh!

mender-test-bot commented Feb 17, 2026

Uh oh!

Uh oh!

mender-test-bot commented Feb 17, 2026

Uh oh!

mender-test-bot commented Feb 17, 2026

Uh oh!

Uh oh!

mender-test-bot commented Feb 17, 2026

Uh oh!

larsewi left a comment

Choose a reason for hiding this comment

Uh oh!

mender-test-bot commented Feb 24, 2026

Uh oh!

mender-test-bot commented Mar 16, 2026

Uh oh!

Uh oh!

mender-test-bot commented Mar 16, 2026

Uh oh!

Uh oh!

larsewi commented Mar 16, 2026

Uh oh!

cf-bottom commented Mar 16, 2026

Uh oh!

larsewi left a comment

Choose a reason for hiding this comment

Uh oh!

mender-test-bot commented Mar 25, 2026

Uh oh!

mender-test-bot commented Mar 25, 2026

Uh oh!

mender-test-bot commented Mar 25, 2026

Uh oh!

victormlg commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victormlg commented Mar 25, 2026

Uh oh!

victormlg commented Mar 26, 2026

Uh oh!

victormlg commented Mar 30, 2026

Uh oh!

larsewi left a comment

Choose a reason for hiding this comment

Uh oh!

victormlg commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

victormlg commented Mar 25, 2026 •

edited

Loading

victormlg commented Apr 6, 2026 •

edited

Loading