Skip to content

44 - Update Fault Table #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
caiodasilva2005 wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

44 - Update Fault Table #45

caiodasilva2005 wants to merge 2 commits into from

Conversation

@caiodasilva2005
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 commented Dec 29, 2025

Changes

  • Modified fault table to reflect the BMS defined in Odyssey-Definitions exactly
  • Updated sm_fault_eval to return a bool since enum was unnecessary

To Do

  • populate the pec error count in hv_plate and acc_data with actual data

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #44

@caiodasilva2005 caiodasilva2005 self-assigned this Dec 29, 2025
@KSMehta11 KSMehta11 mentioned this pull request Jan 2, 2026
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@caiodasilva2005 caiodasilva2005

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[State Machine] - Update Fault Table To Reflect Odyssey Definitions

2 participants

@caiodasilva2005