Added basic implementation for precharge. One function for initializi… #34
Conversation
…ng a given struct to given values, another one for running in an infinite loop.
| float lower_ratio; | ||
| nertimer_t debounce_timer; | ||
| uint32_t debounce_time; | ||
| } prechargeconfig_t; |
There was a problem hiding this comment.
Love the struct for this, could you maybe add some docs for what each field is for?
Core/Inc/precharge_routine.h
Outdated
| * @param precharge_config is the empty configuration to configure. | ||
| * @return a precharge configuration for running the precharge thread. | ||
| */ | ||
| prechargeconfig_t *precharge_init(cell_asic_2950 ic, SPI_HandleTypeDef *hspi, |
There was a problem hiding this comment.
Can we add an assert that the transition ration is <= 1 and >= 0 and that hspi is not null
Core/Inc/precharge_routine.h
Outdated
| * @brief Runs the pre-charge until the threshold-ratio is reached, after which the AIR switch is set to open. | ||
| * @param precharge_config is the configuration to run. | ||
| */ | ||
| void precharge_run(prechargeconfig_t *precharge_config); No newline at end of file |
There was a problem hiding this comment.
nit: rename to vPrecharge like the tasks defined in shep_tasks.c and define it there. You can also set the thread parameters like delays (let's probably do about 500 ms to start) and other settings there. Use other tasks as a reference
Core/Inc/precharge_routine.h
Outdated
| /** | ||
| * @brief Given the cell, SPI, AIR switch, initializes the pre-charge structure for the given BATT/TS voltage capacitor threshold ratio, | ||
| * and with the given debounce time to wait when the AIR opens before closing again.ADI1_delay_ms | ||
| * @param ic idk what this is T-T. |
There was a problem hiding this comment.
this is the struct for the 2950 chipon hv plate for docs
Core/Inc/precharge_routine.h
Outdated
| * @brief Given the cell, SPI, AIR switch, initializes the pre-charge structure for the given BATT/TS voltage capacitor threshold ratio, | ||
| * and with the given debounce time to wait when the AIR opens before closing again.ADI1_delay_ms | ||
| * @param ic idk what this is T-T. | ||
| * @param hspi idk what this is either T-T. |
There was a problem hiding this comment.
this is the struct for the spi handler that goes into the isospi channel wae are using to comm to the chip for docs
Core/Src/precharge_routine.c
Outdated
|
|
||
| void precharge_run(prechargeconfig_t *precharge_config) | ||
| { | ||
| if (precharge_config == NULL) { |
There was a problem hiding this comment.
Make this an assert here, the code should crash if something critical like this is missing
Core/Src/precharge_routine.c
Outdated
| &precharge_config->debounce_timer)) { | ||
| cancel_timer(&precharge_config->debounce_timer); | ||
| } else { | ||
| // SOME SORT OF DELAY? |
There was a problem hiding this comment.
See above comment for delay timings, but yes a delay here is necessary
Core/Src/precharge_routine.c
Outdated
| precharge_config->debounce_time); | ||
| } | ||
| } | ||
| // DELAY? |
There was a problem hiding this comment.
See above comment about delay time.
Core/Src/precharge_routine.c
Outdated
| precharge_config->hspi, | ||
| precharge_config->gpo); | ||
| air_switch_closed = false; | ||
| // I would assume there could be a voltage spike here as well. |
There was a problem hiding this comment.
this is good logic, comment can be removed
Core/Src/precharge_routine.c
Outdated
| } | ||
| } else if (!air_switch_closed) { | ||
| // Check if charged up until threshold. | ||
| // Should there be another check for depleted battery voltage? |
There was a problem hiding this comment.
ah do you mean like welded AIR check? Let's not have that here now (not really in scope). This comment can be removed
…ng a given struct to given values, another one for running in an infinite loop.
Changes
Function that takes an empty struct and initializes it with given values + function that runs an infinite loop for voltages.
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #5