Skip to content

Removed Extra BMS Faults #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
caiodasilva2005 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed Extra BMS Faults #11

caiodasilva2005 wants to merge 1 commit into from

Conversation

@caiodasilva2005
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 commented Nov 29, 2025

Justification:

  • These faults reflect the current BMS fault table
  • These also adds segment comm errors and hv plate comms errors for if we receive PEC errors on isoSPI comms
  • There were some pack-wide faults that we had even though we just look at the min cell volts/temps so those were removed
  • this can be work in progress and more faults can be added pretty easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jr1221 jr1221 jr1221 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caiodasilva2005 @jr1221