Skip to content

#4172 started cr approve slack button#4202

Open
staysgt wants to merge 7 commits into
feature/descoping-crfrom
#4172-cr-slack-button
Open

#4172 started cr approve slack button#4202
staysgt wants to merge 7 commits into
feature/descoping-crfrom
#4172-cr-slack-button

Conversation

@staysgt
Copy link
Copy Markdown
Contributor

@staysgt staysgt commented May 12, 2026

Changes

Added the ability for user's to approve change requests via slack. Tested using Finishling Testing slack app and ngrok to redirect url.

Screenshots

When the cr is submitted:
Screenshot 2026-05-11 at 9 35 18 PM
After the cr has been approved in slack:
Screenshot 2026-05-11 at 9 35 36 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4172

@staysgt staysgt self-assigned this May 12, 2026
@staysgt staysgt requested a review from wavehassman May 12, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants