Skip to content

#4166 maintenance slack task deadline ordering #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rowanssss wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −2
Open

#4166 maintenance slack task deadline ordering #4191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
547b82f
added two layers of task sorting. one at db retrieval and one at the …
Rowanssss Apr 27, 2026
25134c3
formatting fix
Rowanssss Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/backend/src/services/notifications.services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ export default class NotificationsService {
},
dateDeleted: null
},
orderBy: {
deadline: 'asc' // earliest (most overdue) first
},
include: {
assignees: {
include: {
Expand Down Expand Up @@ -78,9 +81,10 @@ export default class NotificationsService {
});
});

// send the notifications to each team for their respective tasks
// send the notifications to each team for their respective tasks sorted by deadline
const promises = Array.from(teamTaskMap).map(async ([slackId, tasks]) => {
const messageBlock = tasks
.sort((a, b) => a.deadline!.getTime() - b.deadline!.getTime())
.map((task) => {
// prisma call earlier allows the forced unwrap (deadline is guaranteed to be a non-null value)
const todayMidnightUTC = new Date(new Date().setUTCHours(0, 0, 0, 0));
Expand Down Expand Up @@ -236,7 +240,6 @@ export default class NotificationsService {
static async sendSponsorTaskNotifications() {
const startOfToday = new Date(new Date().setUTCHours(0, 0, 0, 0));
const endOfToday = startOfDayTomorrow();

const sponsorTasks = await prisma.sponsor_Task.findMany({
where: {
notifyDate: {
Expand Down
Loading