Skip to content

#4008 bom improvements misc changes#4010

Merged
chpy04 merged 4 commits intodevelopfrom
#4008-bom-misc-changes
Mar 5, 2026
Merged

#4008 bom improvements misc changes#4010
chpy04 merged 4 commits intodevelopfrom
#4008-bom-misc-changes

Conversation

@wavehassman
Copy link
Contributor

Changes

  • When creating a material from an RR, it only shows the required fields first and then there is an "add additional details" dropdown that shows everything else
  • Default the quantity to 1 for all materials regardless of creation location
  • Fixed loading issue
  • When opening the create new material form from the RR page the status should default to "ready to order"
  • Not option to select an RR number when creating a material in the RR page
  • When viewing a RR, there is a link back to the bom page for each of the materials

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4008

@wavehassman wavehassman self-assigned this Mar 5, 2026
@wavehassman wavehassman requested a review from chpy04 March 5, 2026 21:31
submitText="Add"
onSubmit={onSubmit}
assemblies={assemblies ?? []}
assembliesLoading={assembliesLoading}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding another prop just for whether something isLoading is kind of redundant. Would be cleaner to just take in an optional parameter and then assume that if it doesn't exist its loading because if it doesn't exist either its loading or it errored. Add an error catch above bc for errors its fine to throw anywhere

control,
errors,
allMaterialTypes,
materialTypesLoading,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for all of these

/>
</FormControl>
</Grid>
{!fromRRForm && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'd like to completely get rid of this functionality on second thought. If they want to retro-actively add a material to an RR they should just edit the RR

control,
errors,
allMaterialTypes,
materialTypesLoading,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same stuff here

@chpy04 chpy04 merged commit 2cfc74a into develop Mar 5, 2026
4 checks passed
@chpy04 chpy04 deleted the #4008-bom-misc-changes branch March 5, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BOM Improvements] - create new material + view RR miscellaneous changes

2 participants