Skip to content

#3927 initial gantt chart filter spacing changes (NOT FINISHED) #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AbhinavGonthina wants to merge 1 commit into
base: feature/gantt-chart-improvements
Choose a base branch
from
Draft

#3927 initial gantt chart filter spacing changes (NOT FINISHED) #3992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/frontend/src/pages/GanttPage/GanttChart/GanttChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,20 +67,21 @@ const GanttChart = <E, T>({
>
<GanttChartTimeline start={startDate} end={endDate} />
<Box sx={{ position: 'relative' }}>
{collections.map((collection) => {
return collection.tasks ? (
<GanttChartCollectionSection
startDate={startDate}
endDate={endDate}
collection={collection}
shouldShowChildren={shouldShowChildren}
onShowChildrenToggle={onShowChildrenToggle}
editability={editability}
/>
) : (
<></>
);
})}
{collections
.filter((collection) => collection.tasks.length > 0)
.map((collection) => {
return (
<GanttChartCollectionSection
key={collection.id}
startDate={startDate}
endDate={endDate}
collection={collection}
shouldShowChildren={shouldShowChildren}
onShowChildrenToggle={onShowChildrenToggle}
editability={editability}
/>
);
})}

{currentWeekCol > 0 && (
<Box
Expand Down
3 changes: 1 addition & 2 deletions src/frontend/src/pages/GanttPage/GanttChart/GanttChartSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ const GanttChartSection = <T,>({
<Box sx={{ mt: '1rem', width: 'fit-content' }}>
{tasks.map((task) => {
return (
<Box display="flex" alignItems="center">
<Box key={task.id} display="flex" alignItems="center">
<GanttTaskBar
key={task.id}
days={days}
task={task}
isEditMode={isEditMode}
Expand Down