Skip to content

Conversation

@chpy04
Copy link
Contributor

@chpy04 chpy04 commented Dec 22, 2025

Changes

  • Switched out of depricated package to bolt api for more modern features
  • Added interactive event listener to allow users to click button on slack to mark things as reimbursed

Notes

  • Because the message is ephemeral, there's no way to delete it if someone marks it as submitted on finishline. Instead, I check in the slack service if its already marked as submitted and just return and delete the message.
  • Had to perform custom validations because its not an http request. Did action validations on the router with a helper for everything that is the same regardless, and then action specific validation in the controller.
  • could probably do some other cool stuff with this

Screenshots

Screenshot 2025-12-21 at 7 42 09 PM Screenshot 2025-12-21 at 7 42 26 PM

If you made UI changes you must post a screenshot of the whole page for each change in 1) a normal sized window and 2) the smallest possible window

If you did any manual testing (e.g., with Postman), put screenshots of the http request and before and after of the db

If none of this applies, you can delete this section

To Do

Any remaining things that need to get done

  • item 1
  • ...

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants