-
Notifications
You must be signed in to change notification settings - Fork 9
#3702 all calendar view #3828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/calendar-improvements
Are you sure you want to change the base?
#3702 all calendar view #3828
Conversation
33fdc2e to
ad5d707
Compare
wavehassman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good start! With Josh's ticket merged in, you should be able to correctly filter events based on calendar. Right now, whenever I press a calendar, all events disappear even the ones from that calendar.
JoshuaGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few requested changes. First off, if no filters are selected, then no events should be displayed (currently it displays all calendar events). This can be done by tweaking the service function to check calendarIds and not calendarIds?.length, and then replacing the undefined in calendarIds: selectedCalendarIds.length ? selectedCalendarIds : undefined with []. Second, all calendar filters should be enabled by default. This gets a little finicky, so you might need a useEffect.
…nto #3702-all-calendar-view merge conflicts
Changes
added the all calendar view so you can filter what calendar's events you want to see on the calendar
Notes
at the first when a calendar was filtered, it would filter out every calendar, so no events would be displayed.
Screenshots
fresh page:

unfiltered:

filtered:

Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3702