Skip to content

Conversation

@samshr27
Copy link
Contributor

@samshr27 samshr27 commented Dec 12, 2025

Changes

added the all calendar view so you can filter what calendar's events you want to see on the calendar

Notes

at the first when a calendar was filtered, it would filter out every calendar, so no events would be displayed.

Screenshots

fresh page:
image

unfiltered:
image

filtered:
image

image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3702

@samshr27 samshr27 self-assigned this Dec 12, 2025
@wavehassman wavehassman changed the base branch from develop to feature/calendar-improvements December 13, 2025 02:09
@samshr27 samshr27 force-pushed the #3702-all-calendar-view branch from 33fdc2e to ad5d707 Compare December 13, 2025 05:14
Copy link
Contributor

@wavehassman wavehassman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good start! With Josh's ticket merged in, you should be able to correctly filter events based on calendar. Right now, whenever I press a calendar, all events disappear even the ones from that calendar.

Copy link
Contributor

@JoshuaGoldberg JoshuaGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few requested changes. First off, if no filters are selected, then no events should be displayed (currently it displays all calendar events). This can be done by tweaking the service function to check calendarIds and not calendarIds?.length, and then replacing the undefined in calendarIds: selectedCalendarIds.length ? selectedCalendarIds : undefined with []. Second, all calendar filters should be enabled by default. This gets a little finicky, so you might need a useEffect.

@wavehassman wavehassman requested a review from chpy04 December 18, 2025 18:57
Samuel Shrestha added 2 commits December 21, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Calendar Improvements] - all calendar view

5 participants