delete rule modal push #3799
Open
delete rule modal push #3799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cielbellerose
requested changes
Dec 10, 2025
Contributor
cielbellerose
left a comment
cielbellerose
left a comment
There was a problem hiding this comment.
great work! Just a small modal design update and this will be perfect
| ? `${titlePrefix} ${rule.ruleCode} - ${rule.ruleContent}` | ||
| : `${titlePrefix} ${rule.ruleCode}`; | ||
|
|
||
| return ( |
Contributor
There was a problem hiding this comment.
This looks really good but we should use the prebuilt NERModal so it better matches the rest of the website. A good example might be the AdminToolsPage/ProjectsConfig/PartTagDeleteModal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the delete rule modal which shows up whenever the delete button on a specific rule is clicked. It includes a calculation of the number of rules that are subsequently deleted. I added utils, api, and hook functions based on the current delete endpoint implemented, but cannot implement the actual delete functionality for the reason below.
Notes
IMPORTANT: Deletion does not actually occur yet just because the current ruleset page does not actually fetch rulesets in the database (there is a placeholder hook right now so real rules are not fetched yet so they can't be deleted) so that needs to be implemented in a future ticket. RIght now, there is just a 404 error.
Screenshots
Deleting one rule with no children
Deleting rules with children (take a look at the rules behind the modal to see the rules that are being deleting and their structures.
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes # (issue #3651 )