-
Notifications
You must be signed in to change notification settings - Fork 9
3604 maintenence tracking spending on project overview #3638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
superhvarn
wants to merge
10
commits into
develop
Choose a base branch
from
3604-maintenence---tracking-spending-on-project-overview
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
3604 maintenence tracking spending on project overview #3638
superhvarn
wants to merge
10
commits into
develop
from
3604-maintenence---tracking-spending-on-project-overview
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chpy04
requested changes
Oct 21, 2025
Contributor
chpy04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple things:
- Basically noone uses the BOM right now, so people are going to want to see information about what the different RRs are for from the RR information. I think there should be room in the grid for that
- "Date" doesn't tell the user which date this is. Right now it is date created, but I think a more useful date would be the date submitted, and then it would be blank for RRs that haven't been bought yet
- We should also include the total budget as well as budget remaining on this page. I think something like a progress bar at the top could be cool but not necessary for this iteration if you don't want to
- We should never have a dropdown that doesn't display any additional information, so if we aren't going to use the dropdown for anything in the case that there is no associated BOM we should just get rid of the dropdown in those cases
- "loading spending history..." instead of loading indicator
- Overall, I think we should convert this into a regular data grid instead of the custom table because while the line items drop down is kind of cool its not really relevant to the overall spending and if someone really needs to know the individual prices of items in an assembly they should just look at the BOM. Also if we do a datagrid it gives us sorting and filtering out of the box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3604 and refers to this slack thread: https://nu-electric-racing.slack.com/archives/C02U5TKHLER/p1758232089244509