Skip to content

Conversation

@superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Oct 3, 2025

Changes

  • New budget tab
  • Project spending history component that updates with reimbursement requests and adds line items according to bom rows that link to project reimbursement requests
  • You can keep track of line items in the component since its a dynamic row of collapsible expandable components
  • filtering functionality based on a number of criteria (main use case is user because of the product request)
  • Condensed pie chart pending categories into one pending reimbursement (this affects the finance page too, lmk if that is not desirable)

Screenshots

Screenshot 2025-10-06 at 6 32 52 PM Screenshot 2025-10-06 at 6 33 09 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3604 and refers to this slack thread: https://nu-electric-racing.slack.com/archives/C02U5TKHLER/p1758232089244509

Copy link
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple things:

  • Basically noone uses the BOM right now, so people are going to want to see information about what the different RRs are for from the RR information. I think there should be room in the grid for that
  • "Date" doesn't tell the user which date this is. Right now it is date created, but I think a more useful date would be the date submitted, and then it would be blank for RRs that haven't been bought yet
  • We should also include the total budget as well as budget remaining on this page. I think something like a progress bar at the top could be cool but not necessary for this iteration if you don't want to
  • We should never have a dropdown that doesn't display any additional information, so if we aren't going to use the dropdown for anything in the case that there is no associated BOM we should just get rid of the dropdown in those cases
  • "loading spending history..." instead of loading indicator
  • Overall, I think we should convert this into a regular data grid instead of the custom table because while the line items drop down is kind of cool its not really relevant to the overall spending and if someone really needs to know the individual prices of items in an assembly they should just look at the BOM. Also if we do a datagrid it gives us sorting and filtering out of the box

Copilot AI review requested due to automatic review settings December 19, 2025 15:28

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenence] - Tracking Spending on Project Overview

3 participants