-
Notifications
You must be signed in to change notification settings - Fork 9
#1192 start date bug #3615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
#1192 start date bug #3615
Conversation
gcooper407
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making those fixes, looks good!
walker-sean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this standard for how we handle dates in the frontend and backend to avoid this issue in other places
Changes
Fix start date off-by-one bug by normalizing client-provided dates to the user’s local midnight converted to UTC before persisting.
Notes
This change is timezone agnostic, so if someone in another timezone chooses a day (e.g. 9/24/25) for the start date, this is the date for everyone else.
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #1192