Skip to content

Conversation

@jasonk55
Copy link
Contributor

@jasonk55 jasonk55 commented Sep 24, 2025

Changes

Fix start date off-by-one bug by normalizing client-provided dates to the user’s local midnight converted to UTC before persisting.

Notes

This change is timezone agnostic, so if someone in another timezone chooses a day (e.g. 9/24/25) for the start date, this is the date for everyone else.

To Do

Any remaining things that need to get done

  • Make the frontend render the date correctly according to user's timezone

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #1192

@jasonk55 jasonk55 self-assigned this Sep 24, 2025
@gcooper407 gcooper407 self-requested a review September 29, 2025 17:49
gcooper407
gcooper407 previously approved these changes Sep 29, 2025
Copy link
Contributor

@gcooper407 gcooper407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making those fixes, looks good!

@superhvarn superhvarn self-assigned this Oct 23, 2025
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this standard for how we handle dates in the frontend and backend to avoid this issue in other places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend - Monday Start Date Changes to Tuesday after a certain time of the day in EST

5 participants