#646 - Adopt Matt Pocock agent skills and restructure Claude Code config by bracyw · Pull Request #647 · Northeastern-Electric-Racing/Argos

bracyw · 2026-06-01T00:59:49Z

Changes

Adopts Matt Pocock's agent-skill framework as the AI-driven path for issue authoring and engineering work, and restructures the repo's Claude Code config to match. Lands in three groups: docs (agent config under docs/agents/, ADR 0002, a workflow glossary), skills (the 14 Matt skills plus the 7 Argos workflow skills, now tracked in .claude/skills/), and code rules (per-subdirectory CLAUDE.md for angular-client and scylla-server, a project-focused root CLAUDE.md, and pruned issue templates).

Two-path issue authoring: AI files via Matt's body shapes through gh issue create, humans keep the YAML form templates; the ready-for-agent label distinguishes AI-filed issues. Rationale and the rejected single-path alternative are in docs/adr/0002-misc-adopt-matt-pocock-skills.md.
commit, open-pr, and update-pr carry small labeled borrows from Matt's caveman and writing-shape skills: terser commit descriptions, plus a format-selection menu and a reader-filter pass for PR bodies.
Five triage labels (needs-triage, needs-info, ready-for-agent, ready-for-human, wontfix) created on the repo; spike and other issue templates removed, leaving task, bug-form, feature-request, epic.

Notes

This is the first committed CLAUDE.md in the repo. It is project-focused (overview, local dev, testing, conventions, safety, plus pointers to the subdir files) and deliberately omits the local bare-repo worktree workflow, which stays in the untracked worktrees-root CLAUDE.md and still parent-merges for that setup.
The two subdir CLAUDE.md files port the former .claude/rules/ frontend and backend guidelines, minus the Cursor-style globs frontmatter that Claude Code ignores.
Follow-ups, intentionally out of this PR: redesigning the worktree-root start-ticket skill to branch on the triage label (autonomous vs interactive), and a post-merge cleanup pass on the local worktree-root skill set.

Test Cases

Confirmed the three commits group cleanly (docs / skills / code rules) with a clean working tree afterward: 54 files, no stray inclusions.
Confirmed the 5 triage labels exist on the repo with the intended colors and descriptions.
Confirmed no merge conflicts against develop.
Spot-checked the migrated skill files and that the docs cross-references resolve.

Checklist

Closes #646

TheJeffreyKuo · 2026-06-01T03:04:22Z

+
+Open the corresponding JSON in the firmware definitions repo:
+```
+/Users/wyattbracy/Desktop/ner/firmware/Odyssey-Definitions/can-messages/


leaks local

…al path

…ontext/

…GitHub-only

TheJeffreyKuo · 2026-06-01T03:57:30Z

+cd angular-client && npm install && npm start
+```
+
+Navigate to the relevant page with Playwright, wait for data, and take a screenshot:


relative pictures/ lands inside the worktree when run from one, which conflicts with the root CLAUDE.md which says screenshots live at worktrees-root, because it risks committing them

TheJeffreyKuo · 2026-06-01T03:57:37Z

+**Section A — Issue tracker.**
+
+> Explainer: The "issue tracker" is where issues live for this repo. Skills like `to-issues`, `triage`, `to-prd`, and `qa` read from and write to it — they need to know whether to call `gh issue create` or follow some other workflow you describe. Pick the place you actually track work for this repo.
+


qa skill doesn't exist

…trees-root

bracyw · 2026-06-01T06:17:24Z

 .playwright-mcp/
 .wolf/
-.claude/
+.context/


add comment, with ironically: context.

bracyw · 2026-06-01T06:37:08Z

@@ -0,0 +1,112 @@
+---


This may benefit from in skill scripts instead of inline bash, do some research on best practice here.

bracyw · 2026-06-01T06:37:53Z

@@ -0,0 +1,49 @@
+---


where is this used, and it should be used by default for most tasks, and specifically this would be a pilot

bracyw · 2026-06-01T06:38:38Z

+## Context
+
+Current branch:
+`!git branch --show-current`


same think with the inline, vs. pre-made script

bracyw · 2026-06-01T07:30:11Z

+#   bash hitl-loop.template.sh
+#
+# Two helpers:
+#   step "<instruction>"          → show instruction, wait for Enter


this may need an example, we should create a ticket to follow up on whether there are any issues with this skill and script usage.

bracyw · 2026-06-01T07:39:31Z

@@ -0,0 +1,116 @@
+---
+name: setup-matt-pocock-skills
+description: Sets up an `## Agent skills` block in AGENTS.md/CLAUDE.md and `docs/agents/` so the engineering skills know this repo's issue tracker (GitHub), triage label vocabulary, and domain doc layout. Run before first use of `to-issues`, `to-prd`, `triage`, `diagnose`, `tdd`, `improve-codebase-architecture`, or `zoom-out` — or if those skills appear to be missing context about the issue tracker, triage labels, or domain docs.


actually have this impletemented as a skill, or add to claude.md setup skills or meant for setup nothing else

bracyw · 2026-06-01T07:40:14Z

@@ -0,0 +1,15 @@
+# Triage Labels


setup skills should be either skills themselves or in docs or in claude.md not here

bracyw · 2026-06-01T07:41:25Z

@@ -0,0 +1,109 @@
+---
+name: tdd


this will need to a ticket revisit how it works during actual usage.

bracyw · 2026-06-01T07:42:31Z

@@ -0,0 +1,182 @@
+---
+name: verify-graph


a little flaky, create follow up ticket to see how it does in actual development

bracyw · 2026-06-01T07:44:46Z

+- Pick the compose profile by what changed:
+  - Frontend-only changes: `./argos.sh client-dev up` runs everything in Docker, including scylla-server.
+  - Changes to `scylla-server/`: `./argos.sh scylla-dev up` (everything except scylla-server) plus `cd scylla-server && cargo run` in a separate terminal, so you are not testing a stale binary.
+- Frontend client: `cd angular-client && npm run start` (default port 4200). The first Angular compile takes 60-90s.


delete the 60-90s, say it will take 10-60s also just point to the run-local skill when possible

and maybe make sure that it is run as a subagent

…DE.md compile time + run-local pointer

… opt-in

bracyw added 3 commits May 31, 2026 17:57

#646 - docs: agent conventions, ADR 0002, glossary

e619418

#646 - skills: Matt set + 7 Argos + inline borrows

410bdcf

#646 - root + subdir CLAUDE.md, prune issue templates

2f3dcff

bracyw self-assigned this Jun 1, 2026

bracyw requested a review from TheJeffreyKuo June 1, 2026 02:40

TheJeffreyKuo requested changes Jun 1, 2026

View reviewed changes

claude added 5 commits June 1, 2026 03:22

#646 - verify-telemetry: link Odyssey-Definitions repo instead of loc…

7be7651

…al path

#646 - verify-telemetry: clone Odyssey-Definitions into gitignored .c…

c785358

…ontext/

#646 - note Unix shell (WSL/Git Bash) requirement for Windows devs

3e37e89

#646 - setup-matt-pocock-skills: drop GitLab/local tracker variants, …

6a927a1

…GitHub-only

#646 - add root CONTEXT.md domain glossary

62bb194

TheJeffreyKuo reviewed Jun 1, 2026

View reviewed changes

claude added 8 commits June 1, 2026 04:55

#646 - screenshots: gitignored pictures/ at repo root instead of work…

973685e

…trees-root

#646 - setup skill: drop dangling qa reference (not adopted)

04f4e1f

#646 - add qa skill: verify branch against issue acceptance criteria

fd2e6b3

#646 - simplify qa skill to build + logic tests with --no-logic flag

15e996a

#646 - remove qa skill: no upstream equivalent, out of scope

038cc83

#646 - drop worktree-specific assumptions from skills and ADR

b90ed07

#646 - de-pin Rust version in backend CLAUDE.md, point to Cargo.toml

9bddb48

#646 - remove skills-lock.json and grill-me skill

57f5aa7

bracyw commented Jun 1, 2026

View reviewed changes

claude added 2 commits June 1, 2026 07:48

#646 - PR review: run-local wording, gitignore .context comment, CLAU…

1fb9cc4

…DE.md compile time + run-local pointer

#646 - PR review: drop setup-matt seed templates, document caveman as…

53cc432

… opt-in

		Section A — Issue tracker.

		> Explainer: The "issue tracker" is where issues live for this repo. Skills like `to-issues`, `triage`, `to-prd`, and `qa` read from and write to it — they need to know whether to call `gh issue create` or follow some other workflow you describe. Pick the place you actually track work for this repo.

Conversation

bracyw commented Jun 1, 2026

Changes

Notes

Test Cases

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants