Detect library type by file extension (xcframework) #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcruz99
force-pushed
the
LLT-6772_add_mixed_xcframework_support
branch
from
cbc1ec7 to
7cae0de
Compare
Collaborator
|
What is the reason for this change? |
sfraczek
reviewed
Dec 12, 2025
Contributor
Author
@tomaszklak It's not possible to create an xcframework with a static and shared lib with the current |
lcruz99
force-pushed
the
LLT-6772_add_mixed_xcframework_support
branch
from
7cae0de to
2ed0a06
Compare
Collaborator
Please add this information to the commit. |
tomaszklak
reviewed
Dec 16, 2025
Currently is not possible to create a xcframework with a static and shared lib. This commit adds library type detection through the file extension. This requires that the file extension match the library type for the respective target.
lcruz99
force-pushed
the
LLT-6772_add_mixed_xcframework_support
branch
from
2ed0a06 to
d0a7289
Compare
Contributor
Author
|
Your comments made me realize that the solution was not robust enough, I've refactored to tackle your concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no support for xcframework assembly with mixed library types (static/shared).
This PR adds automatic detection based on the binary extensions that are provided on the dist/ directory.
(breaking change)