Introduce endpoint provider preference #1609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfraczek
reviewed
Dec 8, 2025
.unreleased/LLT-6880
Outdated
| @@ -0,0 +1 @@ | |||
| LLT-6880: Introduce endpoint provider preference order. Prefer Local endpoints more than others. | |||
Contributor
There was a problem hiding this comment.
I think this will result in line like
- LLT-6880: LLT-6880: Introduce....
generate_changelog.py takes the ticket from the filename (_match_ticket(filename)) and always prepends it when entry_ticket_id is present:
it uses ENTRY_FORMAT_W_TICKET = "* {}: {}\n" and calls ENTRY_FORMAT_W_TICKET.format(entry_ticket_id, line.strip())
it does not strip a leading ticket from the file content, so if line.strip() already begins with LLT-6880:, the output becomes * LLT-6880: LLT-6880: Introduce...
Whenever there exists multiple paths between two devices to connect within meshnet - we were choosing _any_ valid path. But those paths are not always equal, therefore it was entirely possible that unpreferable path would be chosen (e.g. going via STUN via public IP and hairpining on router instead of LAN IPs). This PR introduces the following preference of endpoint providers: * Most prefered - local * Medium prefered - UPnP * Least prefered - STUN and whenever an upgrade is required - this preference is reflected in the endpoint choice. Note: There is a limitation, that if one endpoint is published significnalty earlier than "more" prefered one - then there preference will only be evaluated after next path transition from relay to direct.
Jauler
force-pushed
the
LLT-6880_introduce_ep_preference
branch
from
c023b33 to
9b746ab
Compare
sfraczek
approved these changes
Dec 9, 2025
Hasan6979
reviewed
Dec 24, 2025
| // Define Endpoint-Provider preference | ||
| // higher == more preferred | ||
| let ep_preference_score = |ep| match ep { | ||
| ApiEndpointProvider::Local => 4, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Whenever there exists multiple paths between two devices to connect within meshnet - we were choosing any valid path. But those paths are not always equal, therefore it was entirely possible that unpreferable path would be chosen (e.g. going via STUN via public IP and hairpining on router instead of LAN IPs).
Solution
This PR introduces the following preference of endpoint providers:
And this order is evaluated everytime there is a transition from relayed path to direct.
Note: There is a limitation, that if one endpoint is published significnalty earlier than "more" prefered one - then there preference will only be evaluated after next path transition from relay to direct.
☑️ Definition of Done checklist