Skip to content

Bump uniffi to 0.28.3 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matszczygiel merged 1 commit into from
May 23, 2025
Merged

Bump uniffi to 0.28.3 #360

matszczygiel merged 1 commit into from
May 23, 2025

Conversation

@matszczygiel
Copy link
Contributor

@matszczygiel matszczygiel commented May 23, 2025 •
edited
Loading

Sadly, this introduced breaking changes and broke tests. That's why this PR is that big

@matszczygiel matszczygiel requested a review from a team as a code owner May 23, 2025 05:47
@matszczygiel matszczygiel force-pushed the msz/LLT-6285-uni-ffi-bump-to-v-0-28-3 branch from d0a58e4 to d74d09d Compare May 23, 2025 05:50
@matszczygiel matszczygiel force-pushed the msz/LLT-6285-uni-ffi-bump-to-v-0-28-3 branch from d74d09d to 72caa9b Compare May 23, 2025 06:03
@matszczygiel matszczygiel force-pushed the msz/LLT-6285-uni-ffi-bump-to-v-0-28-3 branch from 72caa9b to 29bd80a Compare May 23, 2025 06:11
@matszczygiel matszczygiel self-assigned this May 23, 2025
@matszczygiel
Bump uniffi to 0.28.3
540d889 
Signed-off-by: Mateusz Szczygieł <mateusz.szczygiel@nordsec.com>
@matszczygiel matszczygiel force-pushed the msz/LLT-6285-uni-ffi-bump-to-v-0-28-3 branch from 29bd80a to 540d889 Compare May 23, 2025 06:15
Lipt0nas
Lipt0nas approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@Lipt0nas Lipt0nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condolenses on having to change that much python code :(

LukasPukenis
LukasPukenis approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@LukasPukenis LukasPukenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matszczygiel matszczygiel merged commit 7653583 into main May 23, 2025
7 of 8 checks passed
@matszczygiel matszczygiel deleted the msz/LLT-6285-uni-ffi-bump-to-v-0-28-3 branch May 23, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lipt0nas Lipt0nas Lipt0nas approved these changes

@LukasPukenis LukasPukenis LukasPukenis approved these changes

Assignees

@matszczygiel matszczygiel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matszczygiel @Lipt0nas @LukasPukenis