Conversation
… perms, shared test support - M1+M2: Extract require_config() private method, replacing 5 duplicate config-loading blocks in service.rs - H1: Add MAX_ALL_PAGES_MESSAGES (10,000) safety cap in execute_paginated_search - H2: Add env = "GRAYLOG_TOKEN" to AuthArgs.token (requires clap env feature) - L1: Set 0o600 file permissions on cache JSON files in config_store.rs - L3: Extract shared FakeCacheStore to src/application/test_support.rs - L4: Skipped - only 2 call sites with different normalizers, not worth extracting - L5: Add help text to 8 positional CLI arguments in cli.rs
ankarhem
force-pushed
the
refactor/code-quality-safety
branch
from
133d2a0 to
123a641
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_config()private method inservice.rs, replacing 5 duplicate config-loading blocksMAX_ALL_PAGES_MESSAGES = 10_000safety cap in paginated searchenv = "GRAYLOG_TOKEN"toAuthArgs.tokenfor token-from-env support0o600file permissions on cache JSON files inconfig_store.rsFakeCacheStoretosrc/application/test_support.rs(deduplicated from service.rs and updater_service.rs tests)#[arg(help = "...")]to all 8 positional CLI argumentsTest plan
cargo checkpasses