Skip to content

Conversation

@yosebyte
Copy link
Contributor

This pull request refactors the advanced settings section of the instance form in the NodePass app. It introduces two new dedicated views—NetworkTuningView and ProtocolControlView—to organize network tuning and protocol control options into navigable subpages, improving clarity and user experience. Additionally, it updates various help texts for consistency and adds corresponding localization keys.

UI Refactoring and Feature Organization:

  • Added NetworkTuningView.swift and ProtocolControlView.swift as new SwiftUI views, and integrated them into the project structure and build phases. These views now handle network tuning and protocol control settings via navigation links from the main instance form. [1] [2] [3] [4] [5] [6]

  • Replaced inline network tuning and protocol control fields in InstanceFormView.swift with navigation links to the new views. Summaries of the current settings are displayed in the main form for quick reference. [1] [2]

User Experience and Text Consistency:

  • Updated help and footer texts throughout InstanceFormView.swift and related views to use consistent punctuation and clearer language. [1] [2] [3] [4] [5] [6] [7]

  • Added and updated localization keys in Shared/Localizable.xcstrings to match revised help texts and new section titles, including "Advanced Settings" and improved descriptions for advanced parameters. [1] [2] [3] [4]

Minor Improvements:

  • Minor code cleanup in InstanceFormView.swift, such as removing unnecessary blank lines and hiding list row separators for additional parameters. [1] [2]

…FormView with new summaries and navigation links
@yosebyte yosebyte requested a review from hiDandelion January 24, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant