Open
Conversation
- Refactored error handling in the MmarClient to streamline response to forwarding errors. - Updated the server's tunnel request validation and error handling for better clarity and maintainability. - Ensured proper resource management by closing response bodies in simulation tests.
- Updated the GRACEFUL_SHUTDOWN_TIMEOUT constant from 3 seconds to 1 second. - Enhanced the shutdown process in the client to allow for quicker cleanup and response to interrupts.
pratikbin
force-pushed
the
fix/sec-and-perf
branch
from
5f47678 to
c5d80e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.