e

[RizonFTW]

Description

Please provide a brief description of the changes introduced in this pull request.

Related Issues

Closes #<issue_number>

Checklist

• My code follows the code style of this project.
• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation, if necessary.
• I have added tests that prove my fix is effective or my feature works.
• New and existing tests pass locally with my changes.

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

• New Features

  • Added Java version selection for Minecraft installation (versions 8, 11, 17, 21, and 25 available)

• Changes

  • Updated Minecraft configuration settings schema

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The PR refactors Minecraft configuration by hardcoding the Docker image as a module-level constant in install.ts and replacing the user-selectable dockerImage setting with a javaVersion select option in settings.ts, offering Java versions 25, 21, 17, 11, and 8 with 25 as the default.

Changes

Docker Image and Java Version Settings Update

Layer / File(s)	Summary
Docker image constant and Java version setting minecraft/install.ts, minecraft/settings.ts	Exported dockerImage constant in install.ts provides the GHCR Minecraft image URL. Settings schema in settings.ts replaces the prior dockerImage setting block with a new javaVersion select configuration (default: "25", options: Java 25, 21, 17, 11, 8). The MinecraftSettings type is updated to match the new schema shape.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• NodeByteHosting/GSG#2: Modifies the same Minecraft configuration files around dockerImage setting and compose generation.
• NodeByteHosting/GSG#1: Affects the exported dockerImage constant used in Minecraft container image composition.

Suggested reviewers

• NodeByteLTD
• CodeMeAPixel

Poem

🐰 A Docker image dockering away,

Java versions now have their say!

Constants are born, selections refound,

Configuration magic, all sound! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description contains only the template with no actual content filled in—no description of changes, no issue reference, and no checklist completion despite clear modifications to Docker image and settings handling.	Complete the description by filling in the actual changes, referencing related issue #, checking off applicable checklist items, and explaining the Docker image and Java version configuration modifications.
Title check	❓ Inconclusive	The pull request title is a single character 'e' which is vague and provides no meaningful information about the actual changes to Minecraft Docker image handling and Java version settings.	Replace the title with a descriptive summary of the main changes, such as 'Add Minecraft Docker image constant and replace dockerImage setting with javaVersion select.'

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch update/mcdocker

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}