Skip to content

docstring base class init #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deven367 merged 3 commits into from
Nov 24, 2025
Merged

docstring base class init #6

deven367 merged 3 commits into from
Nov 24, 2025

Conversation

@deven367
Copy link
Contributor

@deven367 deven367 commented Nov 21, 2025

This PR handles the edge case in neuralforecast where

  1. The docstring in BaseAuto is at the class level, (not in the __init__ method), the docstring in init method is empty (so there's nothing to inherit)
  2. AutoRNN has a docstring in the __init__ method, as the BaseAuto class has an empty docstring in the init, we see that result

nasaul
nasaul approved these changes Nov 24, 2025
View reviewed changes
Copy link

@nasaul nasaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven367 deven367 merged commit 07db08f into main Nov 24, 2025
1 check passed
@deven367 deven367 deleted the docstring-base-class-init branch November 24, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nasaul nasaul nasaul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deven367 @nasaul