Open
Conversation
nixpkgs-ci
bot
added
8.has: package (new)
kloenk
approved these changes
Mar 31, 2026
Member
kloenk
left a comment
kloenk
left a comment
There was a problem hiding this comment.
LGTM, starts on my aarch64-linux (where the old raysession on master seems to be broken)
nixpkgs-ci
bot
added
the
12.approvals: 1
13 tasks
langsjo
reviewed
Apr 5, 2026
Contributor
langsjo
left a comment
langsjo
left a comment
There was a problem hiding this comment.
small suggestions, otherwise lgtm
Contributor
|
langsjo
approved these changes
Apr 5, 2026
Contributor
langsjo
left a comment
langsjo
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
nixpkgs-ci
bot
added
12.approvals: 2
VojtechStep
force-pushed
the
feature/raysession-0.17.4
branch
from
ec30897 to
4b8a473
Compare
VojtechStep
force-pushed
the
feature/raysession-0.17.4
branch
from
4b8a473 to
a147129
Compare
VojtechStep
changed the title
Author
|
Upstream released 0.18 which fixes the starting issue with non-pipewire jack and non-executable shell scripts, so this PR is now targeting that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RaySession 0.17 switched from Qt5 to Qt6 and changed the underlying JACK python bindings from pyjacklib to jack-client, so I packaged that as well. I'd appreciate some feedback on the way I ended up handling the libpath.
I'm actively using this with pipewire-jack, so I guess this fixes #323195.
On the other hand 0.17 doesn't work for me with jackd; IIUC it's because jackd doesn't support the metadata API, which should be optional for raysession but is currently not handled properly. Upstream patched this in an unreleased version, which I tried usingand that worked with jackd for me.Upstream released 0.18 with the fix.I also fixed the bash completions for
ray_control.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.