Skip to content

fix(tmux): add config options to prevent OSC response leak into Neovim buffer #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e-cal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tmux): add config options to prevent OSC response leak into Neovim buffer #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lua/opencode/config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ local defaults = {
},
tmux = {
options = "-h", -- Open in a horizontal split
focus = false, -- Keep focus in Neovim
disable_passthrough = true, -- Prevent OSC response leak (e.g. "=31337;OK")
},
},
}
Expand Down
18 changes: 16 additions & 2 deletions lua/opencode/provider/tmux.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ Tmux.name = "tmux"
---
---`tmux` options for creating the pane.
---@field options? string
---
---Focus the opencode pane when created. Default: `false`
---@field focus? boolean
--
---Disable `allow-passthrough` on the opencode pane.
-- Prevents leaking escape sequences when allow-passthrough is on in tmux.
---Default: `true`
---@field disable_passthrough? boolean

---@param opts? opencode.provider.tmux.Opts
---@return opencode.provider.Tmux
Expand Down Expand Up @@ -74,8 +82,14 @@ function Tmux:start()
local pane_id = self:get_pane_id()
if not pane_id then
-- Create new pane
self.pane_id =
vim.fn.system(string.format("tmux split-window -d -P -F '#{pane_id}' %s '%s'", self.opts.options, self.cmd))
local detach_flag = self.opts.focus and "" or "-d"
self.pane_id = vim.fn.system(
string.format("tmux split-window %s -P -F '#{pane_id}' %s '%s'", detach_flag, self.opts.options or "", self.cmd)
)
local disable_passthrough = self.opts.disable_passthrough ~= false -- default true
if disable_passthrough and self.pane_id and self.pane_id ~= "" then
vim.fn.system(string.format("tmux set-option -t %s -p allow-passthrough off", vim.trim(self.pane_id)))
end
end
end

Expand Down