Resolution of merge conflicts for inherited classes PR #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoNameProvided
force-pushed
the
develop
branch
from
2f7b814 to
4056f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @NickKelly1! Almost two years ago you created a contribution to class-validator in which you solved an issue where classes skipped inherited validation.
I ran into the same issue and checked out the solution that you created. It seemed that it's still a good solution and that there was only a minor merge conflict in a test file. I resolved the merge conflict and it should be good to go.
This PR to your clone should bring your
developbranch up-to-date with thedevelopbranch ofclass-validator.I would greatly appreciate it if you see the opportunity to merge this, such that your contribution can be merged into
class-validator. Alternatively, I understand that after two years your time or motivation has waned to pursue this, in which case I am happy to submit my own PR toclass-validator, with full recognition of your work.Either way, thanks for your work!