Skip to content

Remove ctb(int) overload and update LuaT enums #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NiceAndPeter merged 2 commits into from
Nov 22, 2025
Merged

Remove ctb(int) overload and update LuaT enums #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e21891
Phase 122: Remove unused ctb(int) overload
claude Nov 22, 2025
0ca0e30
Phase 122: Remove 6 additional unused legacy functions from ltvalue.h
claude Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/objects/ltvalue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,8 @@ class TValue {
};


/* Access to TValue's internal value union */
constexpr Value& val_(TValue* o) noexcept { return o->valueField(); }
constexpr const Value& val_(const TValue* o) noexcept { return o->valueField(); }
constexpr Value& valraw(TValue* o) noexcept { return val_(o); }
constexpr const Value& valraw(const TValue* o) noexcept { return val_(o); }


/* raw type tag of a TValue */
constexpr LuaT rawtt(const TValue* o) noexcept { return o->getType(); }
constexpr lu_byte rawtt_byte(const TValue* o) noexcept { return o->getRawType(); } /* for legacy code */

/* tag with no variants (bits 0-3) */
constexpr int novariant(int t) noexcept { return (t & 0x0F); }
Expand All @@ -296,7 +288,6 @@ constexpr int withvariant(int t) noexcept { return (t & 0x3F); }
constexpr LuaT withvariant(LuaT t) noexcept { return static_cast<LuaT>(static_cast<int>(t) & 0x3F); }

constexpr LuaT ttypetag(const TValue* o) noexcept { return withvariant(rawtt(o)); }
constexpr lu_byte ttypetag_byte(const TValue* o) noexcept { return static_cast<lu_byte>(withvariant(rawtt(o))); } /* for legacy code */

/* type of a TValue */
constexpr int ttype(const TValue* o) noexcept { return novariant(rawtt(o)); }
Expand All @@ -307,15 +298,13 @@ constexpr LuaT TValue::typeTag() const noexcept { return withvariant(tt_); }

/* Macros to test type */
constexpr bool checktag(const TValue* o, LuaT t) noexcept { return rawtt(o) == t; }
constexpr bool checktag(const TValue* o, lu_byte t) noexcept { return rawtt(o) == static_cast<LuaT>(t); } /* overload for raw bytes */
constexpr bool checktype(const TValue* o, int t) noexcept { return ttype(o) == t; }

/* Bit mark for collectable types */
inline constexpr int BIT_ISCOLLECTABLE = (1 << 6);

/* mark a tag as collectable */
constexpr LuaT ctb(LuaT t) noexcept { return static_cast<LuaT>(static_cast<int>(t) | BIT_ISCOLLECTABLE); }
constexpr lu_byte ctb(int t) noexcept { return static_cast<lu_byte>(t | BIT_ISCOLLECTABLE); } /* overload for base types */


/* Macros for internal tests */
Expand All @@ -327,7 +316,6 @@ constexpr lu_byte ctb(int t) noexcept { return static_cast<lu_byte>(t | BIT_ISCO

/* set a value's tag */
inline void settt_(TValue* o, LuaT t) noexcept { o->setType(t); }
inline void settt_(TValue* o, lu_byte t) noexcept { o->setType(t); } /* overload for raw bytes */


#endif
Loading