Reorganize MakeVariant constants in ltvalue.h #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralized all makevariant-based type variant constants in ltvalue.h for better organization and maintainability. This consolidation improves code organization by placing all type variant definitions in a single location immediately after the makevariant function definition. Changes: - Moved LUA_TUPVAL and LUA_TPROTO type definitions to ltvalue.h - Moved all makevariant constants to ltvalue.h: * Nil variants: LUA_VNIL, LUA_VEMPTY, LUA_VABSTKEY, LUA_VNOTABLE * Boolean variants: LUA_VFALSE, LUA_VTRUE * Number variants: LUA_VNUMINT, LUA_VNUMFLT * String variants: LUA_VSHRSTR, LUA_VLNGSTR * Table variant: LUA_VTABLE * Function variants: LUA_VLCL, LUA_VLCF, LUA_VCCL * Userdata variants: LUA_VLIGHTUSERDATA, LUA_VUSERDATA * Thread variant: LUA_VTHREAD * Upvalue variant: LUA_VUPVAL * Proto variant: LUA_VPROTO - Removed duplicate definitions from: * lobject_core.h (11 constants) * lstring.h (2 constants) * lfunc.h (4 constants) * ltable.h (1 constant) * lproto.h (1 constant) - Added documentation comments to indicate new locations All tests pass. Build time: ~3s, Test time: 4.62s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralized all makevariant-based type variant constants in ltvalue.h for better organization and maintainability. This consolidation improves code organization by placing all type variant definitions in a single location immediately after the makevariant function definition.
Changes:
All tests pass. Build time: ~3s, Test time: 4.62s