Remove unnecessary inline specifiers #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Removed redundant 'inline' keywords from member functions defined inside class bodies. In C++, such functions are implicitly inline, making the explicit keyword unnecessary and verbose. Changes: - ltable.h: Node class (20 methods), Table class (8 methods) - lproto.h: ProtoDebugInfo (29 methods), Proto (58 methods) - lparser.h: Labellist (11 methods), Dyndata (11 methods), ActvarAccessor (4 methods), CodeBuffer (13 methods), ConstantPool (5 methods), VariableScope (7 methods), RegisterAllocator (4 methods), UpvalueTracker (4 methods) - lstack.h: LuaStack class (19 methods) - llex.h: InputScanner (11 methods), TokenState (4 methods), StringInterner (10 methods) Total: ~218 redundant inline specifiers removed across 5 header files. This change improves code clarity without affecting performance. Member functions defined within class bodies are implicitly inline per C++ standard. Note: Free functions and member functions defined outside class bodies still require explicit 'inline' to avoid ODR violations. Performance: 4.33s avg (5 runs: 4.70s, 4.25s, 4.15s, 4.34s, 4.20s) Target: ≤4.33s ✅ Tests: All passing ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions
Removed redundant 'inline' keywords from member functions defined inside class bodies. In C++, such functions are implicitly inline, making the explicit keyword unnecessary and verbose.
Changes:
Total: ~218 redundant inline specifiers removed across 5 header files.
This change improves code clarity without affecting performance. Member functions defined within class bodies are implicitly inline per C++ standard.
Note: Free functions and member functions defined outside class bodies still require explicit 'inline' to avoid ODR violations.
Performance: 4.33s avg (5 runs: 4.70s, 4.25s, 4.15s, 4.34s, 4.20s)
Target: ≤4.33s ✅
Tests: All passing ✅