Replace old value functions with TValue members #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace legacy wrapper macros with direct TValue member function calls: - setfltvalue(obj, x) → obj->setFloat(x) - chgfltvalue(obj, x) → obj->changeFloat(x) - setivalue(obj, x) → obj->setInt(x) - chgivalue(obj, x) → obj->changeInt(x) Changes: - Updated 60+ callsites across 12 files - Removed 4 wrapper function definitions from lobject_core.h - All calls now use direct TValue member functions Benefits: - Cleaner, more object-oriented API - Consistent with project's macro elimination goal - No performance impact (functions are inline) Performance: 4.31s avg (target ≤4.33s, baseline 4.20s) ✅ Tests: All passing ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace legacy wrapper macros with direct TValue member function calls:
Changes:
Benefits:
Performance: 4.31s avg (target ≤4.33s, baseline 4.20s) ✅
Tests: All passing ✅