Complete phase 112 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Phase 112 broke Clang builds due to -Wsign-conversion errors when passing int sizes to std::span constructor (expects size_t). Changes: - Added static_cast<size_t> to all span constructor calls in: - Proto::getCodeSpan() (sizecode) - Proto::getConstantsSpan() (sizek) - Proto::getProtosSpan() (sizep) - Proto::getUpvaluesSpan() (sizeupvalues) - ProtoDebugInfo::getLineInfoSpan() (sizelineinfo) - ProtoDebugInfo::getAbsLineInfoSpan() (sizeabslineinfo) - ProtoDebugInfo::getLocVarsSpan() (sizelocvars) - Fixed ldump.cpp subspan calls: - locvars.subspan(0, n) → locvars.subspan(0, static_cast<size_t>(n)) - upvalues.subspan(0, n) → upvalues.subspan(0, static_cast<size_t>(n)) Result: - ✅ GCC build: passes (4.73s avg) - ✅ Clang build: now compiles successfully (4.51s avg) - ✅ All tests passing: final OK !!! Note: Performance variance observed (4.16s-5.56s range), investigating separately. Primary goal achieved: Clang compatibility restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.