Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ jobs:
secrets: inherit

test:
needs: lint
uses: NicTool/.github/.github/workflows/test.yml@main
secrets: inherit
2 changes: 1 addition & 1 deletion .release
Submodule .release updated 1 files
+2 −2 finish.sh
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).

### Unreleased

### [0.8.4] - 2026-03-14

- disable domain validation, until joi.string.domain supports /
- related: hapijs/address#48

### [0.8.3] - 2026-03-13

- ns: NSD -> nsd
Expand Down Expand Up @@ -97,3 +102,4 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
[0.8.1]: https://github.com/NicTool/validate/releases/tag/v0.8.1
[0.8.2]: https://github.com/NicTool/validate/releases/tag/v0.8.2
[0.8.3]: https://github.com/NicTool/validate/releases/tag/v0.8.3
[0.8.4]: https://github.com/NicTool/validate/releases/tag/v0.8.4
2 changes: 1 addition & 1 deletion CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This handcrafted artisanal software is brought to you by:

| <img height="80" src="https://avatars.githubusercontent.com/u/261635?v=4"><br><a href="https://github.com/msimerson">msimerson</a> (<a href="https://github.com/NicTool/validate/commits?author=msimerson">22</a>) |
| <img height="80" src="https://avatars.githubusercontent.com/u/261635?v=4"><br><a href="https://github.com/msimerson">msimerson</a> (<a href="https://github.com/NicTool/validate/commits?author=msimerson">23</a>) |
| :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: |

<sub>this file is generated by [.release](https://github.com/msimerson/.release).
Expand Down
3 changes: 2 additions & 1 deletion lib/zone.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ const shared = require('./shared')

exports.id = shared.uint32

exports.zone = Joi.string().min(3).max(255).domain({ allowFullyQualified: true, tlds: false })
exports.zone = Joi.string().min(3).max(255)
// .domain({ allowFullyQualified: true, allowUnderscore: true, tlds: false })

exports.v3 = Joi.object({
id: exports.id,
Expand Down
2 changes: 1 addition & 1 deletion lib/zone.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('zone', function () {
.map((a) => `thisis${a}atest.com.`)

for (const char of invalid_chars) {
it(`rejects invalid: ${char}`, () => {
it.skip(`rejects invalid: ${char}`, () => {
const testCase = JSON.parse(JSON.stringify(testZone))
testCase.zone = char

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nictool/validate",
"version": "0.8.3",
"version": "0.8.4",
"description": "NicTool Object Validation",
"files": [
"lib",
Expand Down Expand Up @@ -66,4 +66,4 @@
"trailingComma": "all",
"printWidth": 100
}
}
}
Loading