Skip to content

25 314 issue with ntk watch#26

Merged
alexphelps merged 8 commits intomasterfrom
25-314-issue-with-ntk-watch
Mar 5, 2026
Merged

25 314 issue with ntk watch#26
alexphelps merged 8 commits intomasterfrom
25-314-issue-with-ntk-watch

Conversation

@alexphelps
Copy link
Member

@alexphelps alexphelps commented Mar 5, 2026

Fix ntk watch compatibility with Python 3.12+ and modernise dependencies with #25

Problem

ntk watch raised a RuntimeError on Python 3.12+ because asyncio.get_event_loop() no longer creates a new event loop implicitly when called outside of a running loop. Also reported by a user on Python 3.14 on macOS.

Changes

Bug fixes

  • Replace asyncio.get_event_loop() / loop.run_until_complete() with asyncio.run() in the watch command
  • Fix watchfiles Change enum logging — use event_type.name.title() instead of str(event_type) which was printing integers (2 instead of Modified)
  • Suppress watchfiles internal log noise (1 change detected) via logger level

Dependencies

  • Replace deprecated watchgod with watchfiles (the maintained successor by the same author)
  • Update python_requires to >=3.10 (Python 3.8/3.9 are EOL)
  • Wire up extras_require={"test": ...} in setup.py so pip install -e ".[test]" works

CI / release pipeline

  • Update CI matrix and tox to test against Python 3.10–3.14
  • Fix release pipeline — replace legacy python setup.py sdist bdist_wheel with python -m build

Tests

  • Add tests for push command (missing, added, and filenames scenarios)
  • Add test verifying asyncio.run() is called by the watch command

Docs

  • Add CLAUDE.md with project overview, dev setup, and conventions
  • Rename 29 NextNext Commerce in docs

@alexphelps alexphelps linked an issue Mar 5, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (873ea17) to head (bd36ecd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   85.83%   88.57%   +2.74%     
==========================================
  Files           7        7              
  Lines         360      359       -1     
==========================================
+ Hits          309      318       +9     
+ Misses         51       41      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexphelps alexphelps merged commit 1dc6a43 into master Mar 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.14 Issue with ntk watch

1 participant