fix: read Stellar network and contract ID from config (#66)#77
Merged
robertocarlous merged 1 commit intoMay 29, 2026
Merged
Conversation
|
@Xaxxoo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ess.env Resolves Neurowealth#66 - removes hardcoded MAINNET fallback in extractNetwork() by using an exhaustive switch on the validated config value, and routes all stellar env reads (RPC URL, network passphrase, vault contract ID) through the central config object so deployments control the network via STELLAR_NETWORK env var.
Xaxxoo
force-pushed
the
fix/issue-66-stellar-network-config
branch
from
6ac0805 to
39d2d97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configobject insrc/stellar/client.tsandsrc/stellar/contract.tsMAINNETfallback inextractNetwork()(events.ts) with an exhaustiveswitchon the validated config value, so the compiler enforces coverage of all three network variantsSTELLAR_NETWORK=testnet|mainnet|futurenetTest plan
STELLAR_NETWORK=testnetand verifyextractNetwork()returnsNetwork.TESTNETSTELLAR_NETWORK=futurenetand verifyextractNetwork()returnsNetwork.FUTURENETSTELLAR_NETWORK=mainnetand verifyextractNetwork()returnsNetwork.MAINNETconfig/env.ts)npm testCloses #66