Skip to content

Unnamed group mixin improvements #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ehennestad wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Unnamed group mixin improvements #784

ehennestad wants to merge 7 commits into from

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Jan 24, 2026 •
edited
Loading

Motivation

Improve upon the changes made in PR #705:

  • Use the UnnamedGroupMixin as a superclass also when a type has unnamed datasets (Example: VectorData in DynamicTable)
  • Support scenario where multiple types in a type hierarchy defines unnamed groups and/or unnamed datasets (Example: AlignedDynamicTable).

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad
Update fillClass.m
a033816
@ehennestad
Refactor HasUnnamedGroups property handling and add hierarchy support
8b6f76e 
- Replaces the abstract protected GroupPropertyNames property with a private dependent property and a static protected method for retrieval.
- Adds caching for GroupPropertyNames
-Implements getGroupPropertyNamesAcrossTypeHierarchy to aggregate unnamed group property names across the class hierarchy.
- Updates fillClass to generate appropriate method overrides for classes with anonymous groups or data.
@ehennestad
Simplify - no need for method injection in subclasses of mixin
441f9f6
@ehennestad
Regenerate types
b59661d
@ehennestad ehennestad marked this pull request as draft January 24, 2026 20:30
@ehennestad
Simplify condition for HasUnnamedGroups mixin
5e746fd 
Refactored the logic to add 'matnwb.mixin.HasUnnamedGroups' as a superclass by combining checks for 'hasAnonGroups' and 'hasAnonData' into a single condition.
@ehennestad
Refine recursion logic in searchProperties function
b2dda0d 
The recursive search should invoked for group-based classes and should only be skipped when the current object is a Set or Anon of a tye which inherits the HasUnnamedGroups mixin
@ehennestad
Merge branch 'fix-nwbfile-searchfor-bug' into unnamed-group-mixin-imp…
8138bf7 
…rovements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ehennestad