Add multidevice #314
Merged
Add multidevice #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial implementation of multi-device configuration
a 'devices' argument has been added to the Experiment class
this will consist of a list of devices, whereas the current setup is to hand a single device to the
eegargumentbehaviour is otherwise identical as to when the single eeg device is handled, but it iterates through the list
the expectation is that in the medium term, this will become the default usage, and the single-device option will be gracefully deprecated
however because this is a major change, this will be done gradually to be sure of no breakages
active testing is currently with the serial and pyxid2 ports (for concurrent biosemi and nirsport recordings); but this should eventually be easily used with, for example, two brainflow devices (eg a muse and a neurosity both worn on the head at the same time), or alternatively eg a muse and a serial device for trigger testing