-
Notifications
You must be signed in to change notification settings - Fork 266
Implement Biocam reader for 3Brain system #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @alejoe91! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-01-25 11:57:10 UTC |
|
@alejoe91 : any news here ? |
Not this week on my side. So you can move it to next release if you are releasing this week! |
|
Hi @alejoe91 Is this PR still alive? |
Hi @JuliaSprenger, let's keep it open. We got stuck because it's unclear how the conversion factors are stored in the file. Or do you prefer to close it and re-open when we get time to work on it? |
|
Ok, then we keep it open and I ping again in some weeks. |
|
Tests depend on this GIN PR: https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/66 |
|
@JuliaSprenger @samuelgarcia this is ready to review. Also added a test file on GIN (PR still need revision) |
|
@JuliaSprenger this seems to be failing for a SpikeGLX problem, but the biocam test passes |
|
Hi Alessio. |
|
@alejoe91 : can you rebase on master and so re run tests ? |
|
Sure |
Uh oh!
There was an error while loading. Please reload this page.