Skip to content

Conversation

@alejoe91
Copy link
Contributor

@alejoe91 alejoe91 commented May 20, 2021

  • test files
  • tests
  • info about gain and offset

@pep8speaks
Copy link

pep8speaks commented May 20, 2021

Hello @alejoe91! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 32:73: W291 trailing whitespace
Line 121:100: E501 line too long (110 > 99 characters)
Line 168:100: E501 line too long (106 > 99 characters)

Line 16:9: E123 closing bracket does not match indentation of opening bracket's line

Comment last updated at 2022-01-25 11:57:10 UTC

@apdavison apdavison added this to the 0.10.0 milestone Jun 11, 2021
@samuelgarcia
Copy link
Contributor

@alejoe91 : any news here ?
Do you think it will be ready soon or do I move this to 0.11 release ?

@samuelgarcia samuelgarcia modified the milestones: 0.10.0, 0.11.0 Jun 15, 2021
@alejoe91
Copy link
Contributor Author

@alejoe91 : any news here ?
Do you think it will be ready soon or do I move this to 0.11 release ?

Not this week on my side. So you can move it to next release if you are releasing this week!

@JuliaSprenger
Copy link
Member

Hi @alejoe91 Is this PR still alive?

@alejoe91
Copy link
Contributor Author

Hi @alejoe91 Is this PR still alive?

Hi @JuliaSprenger, let's keep it open. We got stuck because it's unclear how the conversion factors are stored in the file. Or do you prefer to close it and re-open when we get time to work on it?

@JuliaSprenger
Copy link
Member

Ok, then we keep it open and I ping again in some weeks.

@alejoe91
Copy link
Contributor Author

Tests depend on this GIN PR: https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/66

@alejoe91 alejoe91 marked this pull request as ready for review November 18, 2021 10:47
@alejoe91
Copy link
Contributor Author

@JuliaSprenger @samuelgarcia this is ready to review. Also added a test file on GIN (PR still need revision)

@alejoe91
Copy link
Contributor Author

@JuliaSprenger this seems to be failing for a SpikeGLX problem, but the biocam test passes

@samuelgarcia
Copy link
Contributor

Hi Alessio.
Cool. Thanks.
I will have a look next week.

@samuelgarcia
Copy link
Contributor

@alejoe91 : can you rebase on master and so re run tests ?

@alejoe91
Copy link
Contributor Author

Sure

@samuelgarcia samuelgarcia merged commit 504dcbe into NeuralEnsemble:master Jan 25, 2022
@apdavison apdavison modified the milestones: 0.10.3, 0.11.0 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants