Adding SC wrapper #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

yger wants to merge 11 commits into NeuralEnsemble:master from yger:master

yger commented Dec 17, 2020

No description provided.


          Adding SC wrapper

3fc6bd8

pep8speaks commented Dec 17, 2020 •

edited

Loading

Hello @yger! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-19 15:07:10 UTC

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Show resolved Hide resolved

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved


          Modifications

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py

		@@ -0,0 +1,183 @@
		"""

Contributor

samuelgarcia Dec 17, 2020

Add some comments here to dscribe the reader and link to the project.

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Show resolved Hide resolved

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved

samuelgarcia reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved

yger added 2 commits

December 17, 2020 16:50


          Private attribute

811bb00


          Tests for SC

0afa459

Contributor

samuelgarcia commented Dec 17, 2020

To have tests passing you maybe have to play with this installtion file:
circleci/requirements_testing.txt

samuelgarcia mentioned this pull request

[wip] implement new OpenEphysIO class for the new format. #908

Closed

Contributor

samuelgarcia commented Jan 8, 2021

Hi Pierre. Could fix pep8 and small comments so I could merge this ?

apdavison added this to the 0.10.0 milestone

Contributor

samuelgarcia commented Mar 5, 2021

Hi Pierre.
Would you time time to finish this for 0.10 release ?
need pass test and pep8 stuff.

samuelgarcia self-assigned this

Author

yger commented Mar 8, 2021

Back from holidays, I'll try to finish that asap

yger added 2 commits

March 10, 2021 13:45


          pep8

521b7f7


          Docs

6b19deb

Contributor

samuelgarcia commented Mar 10, 2021

@yger : the rawio API have change a bit. Can you try to rebase to master ?
I can help you.

apdavison modified the milestones: 0.10.0, 0.11.0

Member

JuliaSprenger commented Sep 23, 2021

@yger Is this PR still alive? I created a rebased version of this branch here in case the rebasing is the issue.

JuliaSprenger added the New IO Class label


          Merge branch 'master' of github.com:NeuralEnsemble/python-neo

a52736b

WIP

d7203f1

JuliaSprenger reviewed

View reviewed changes

neo/rawio/spykingcircusrawio.py Outdated Show resolved Hide resolved


          Update neo/rawio/spykingcircusrawio.py

d912ccc

JuliaSprenger reviewed

View reviewed changes

neo/test/iotest/test_spykingcircus.py Outdated Show resolved Hide resolved

JuliaSprenger reviewed

View reviewed changes

neo/test/rawiotest/test_spykingcircusrawio.py Outdated Show resolved Hide resolved

JuliaSprenger added 2 commits

October 19, 2021 17:06


          Update neo/test/iotest/test_spykingcircus.py

44a1be4


          Update neo/test/rawiotest/test_spykingcircusrawio.py

Member

JuliaSprenger commented Mar 31, 2022

Hi @samuelgarcia If I understood you correctly you want to not add SC to the Neo IOs, but instead to SpikeInterface. Does this make sense? Maybe it would still make sense to be able to load it here?

samuelgarcia closed this

apdavison modified the milestones: 0.10.3, 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels