Skip to content

Make neuroshare robust for non-conform units #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samuelgarcia merged 1 commit into from
Jun 23, 2022
Merged

Make neuroshare robust for non-conform units #1122

samuelgarcia merged 1 commit into from
Jun 23, 2022

Conversation

@JuliaSprenger
Copy link
Member

@JuliaSprenger JuliaSprenger commented May 20, 2022 •
edited
Loading

and refactor test

@JuliaSprenger
Copy link
Member Author

JuliaSprenger commented Jun 9, 2022

@samuelgarcia What do you think? This PR is going along with https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/78

@JuliaSprenger JuliaSprenger added this to the 0.11.0 milestone Jun 23, 2022
@samuelgarcia samuelgarcia merged commit 6fc2329 into NeuralEnsemble:master Jun 23, 2022
@JuliaSprenger JuliaSprenger deleted the enh/neuroshare branch June 24, 2022 08:32
@apdavison apdavison modified the milestones: 0.10.3, 0.11.0 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelgarcia samuelgarcia samuelgarcia approved these changes

Assignees

@samuelgarcia samuelgarcia

Labels

None yet

Projects

None yet

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JuliaSprenger @samuelgarcia @apdavison