-
Notifications
You must be signed in to change notification settings - Fork 266
Add new github actions. #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new github actions. #1093
Conversation
|
If tests pass I will remove Travis |
|
This is now 45 jobs (3 * 3 * 5) for the core. |
|
Looks good to me. Do you think it would make sense to run the io tests only once the core tests succeed or should be keep this independent? |
|
Yes I was think something like this : run io and rawio only if core is passing (~3min). |
|
Ok, then I will merge this in the current state and we can add chaining later. |
|
For testing, we decided on NEP29 + 1 year, so we should be testing Python 3.7+ and NumPy 1.17+. I suggest we test all combinations for the core tests, but only the oldest and newest for io tests. |
|
thanks for merging. Andrew, for cortest you suggest all numpy version from 1.17 to 1.22 ? For iotest I don't think we have to go for a matrix f os/python/numpy. |
|
In this PR you're already testing 5 NumPy versions, so I'm suggesting only one more. I would agree about removing osx testing, and maybe we can also run a smaller matrix on Windows. |
|
Lets discuss in this PR #1096 |
@JuliaSprenger @apdavison @mdenker
This GH actions will replace travis one.
It run on several os/python/numpy.