Skip to content

Conversation

@SimoneAriens
Copy link
Collaborator

drawio overview of the endpoints with the most recent changes:

  • prepare_marks endpoint split in two -> one for impression and one for striation
  • edit_image endpoint no longer returns the x3p path
  • flow of input to specific blocks is made more explicit

in pycharm you can install the plugin to view and update the diagram: https://plugins.jetbrains.com/plugin/15635-diagrams-net-integration

@Raytesnel
Copy link
Collaborator

Raytesnel commented Jan 21, 2026

The input keys for prepare-mark are preprocess_striation_params and for impression. maybe it is nicer to keep the striation out of the key name. due we are already posting it to a impression or striation endpoint

@SimoneAriens
Copy link
Collaborator Author

change npy to npz

@github-actions
Copy link

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
. 96% 88%
comparators 100% 100%
container_models 99% 100%
conversion 96% 89%
conversion.export 100% 100%
conversion.leveling 100% 100%
conversion.leveling.solver 100% 75%
conversion.preprocess_impression 99% 92%
extractors 96% 75%
parsers 98% 67%
parsers.patches 89% 60%
preprocessors 100% 100%
processors 100% 100%
renders 98% 50%
utils 91% 75%
Summary 97% (1289 / 1323) 85% (137 / 162)

Minimum allowed line rate is 50%

Copy link
Collaborator

@Raytesnel Raytesnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimoneAriens SimoneAriens merged commit 6caa5e8 into main Jan 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants