Skip to content

fix(reverse proxy): removed server tokens, added good default headers #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tbaile wants to merge 4 commits into from
Closed

fix(reverse proxy): removed server tokens, added good default headers #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a560c2
fix(ns-ui): removed ui tokens and strenghtened config
Tbaile Jan 12, 2026
dd3810c
fix(ns-api): removed server tokens for reverse proxies
Tbaile Jan 12, 2026
11bbcaf
got lost in 2025
Tbaile Jan 12, 2026
cb8cb58
chore(deps): update dependency nethserver/python3-nethsec to v1.4.6
Tbaile Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ns-api/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=ns-api
PKG_VERSION:=3.4.4
PKG_VERSION:=3.4.5
PKG_RELEASE:=1

PKG_BUILD_DIR:=$(BUILD_DIR)/ns-api-$(PKG_VERSION)
Expand Down Expand Up @@ -190,6 +190,7 @@ define Package/ns-api/install
$(INSTALL_BIN) ./files/uci-defaults/99-ns-api.synflood $(1)/etc/uci-defaults
$(INSTALL_BIN) ./files/uci-defaults/99-ns-api.dnsmasq $(1)/etc/uci-defaults
$(INSTALL_BIN) ./files/uci-defaults/99-ns-api.wireguard $(1)/etc/uci-defaults
$(INSTALL_BIN) ./files/uci-defaults/99-ns-api.nginx $(1)/etc/uci-defaults
$(INSTALL_DIR) $(1)/usr/libexec
$(INSTALL_BIN) ./files/misc/wireguard-migrate.py $(1)/usr/libexec/wireguard-migrate
endef
Expand Down
14 changes: 14 additions & 0 deletions packages/ns-api/files/uci-defaults/99-ns-api.nginx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/bin/sh

#
# Copyright (C) 2026 Nethesis S.r.l.
# SPDX-License-Identifier: GPL-2.0-only
#

# Iterates over the configuration sections to disable server tokens
servers=$(uci show nginx | grep -Po '^nginx.([A-Za-z0-9_]+)=server$' | cut -d'.' -f2 | cut -d'=' -f1)
for server in $servers; do
if [ -z "$(uci -q get "nginx.${server}.server_tokens")" ]; then
uci set "nginx.$server.server_tokens=off"
fi
done
2 changes: 1 addition & 1 deletion packages/ns-ui/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=ns-ui
# renovate: datasource=github-releases depName=NethServer/nethsecurity-ui
PKG_VERSION:=2.8.1
PKG_RELEASE:=1
PKG_RELEASE:=2

PKG_SOURCE:=ui-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=https://nethsecurity.ams3.digitaloceanspaces.com/ui-dist/
Expand Down
6 changes: 6 additions & 0 deletions packages/ns-ui/files/ns-ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ server {
ssl_session_timeout 64m;
error_log syslog:server=unix:/dev/log,nohostname;
access_log syslog:server=unix:/dev/log,nohostname;
server_tokens off;
add_header X-Content-Type-Options "nosniff";
add_header Permissions-Policy "()";
add_header Referrer-Policy "no-referrer";
add_header Content-Security-Policy "default-src 'self'";
add_header Cache-Control "max-age=1800";

# enable NS UI
location / {
Expand Down
2 changes: 1 addition & 1 deletion packages/python3-nethsec/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=python3-nethsec
# renovate: datasource=github-tags depName=NethServer/python3-nethsec
PKG_VERSION:=1.4.5
PKG_VERSION:=1.4.6
PKG_RELEASE:=1

PKG_MAINTAINER:=Giacomo Sanchietti <giacomo.sanchietti@nethesis.it>
Expand Down
Loading