Skip to content

Conversation

@jun-he
Copy link
Contributor

@jun-he jun-he commented Dec 4, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew build --write-locks to refresh dependencies)
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Change to send external workflow deletion notification after the workflow deletion is completed.

@jun-he jun-he requested a review from Copilot December 4, 2025 21:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where external workflow deletion notifications were sent before the workflow deletion was completed. The change ensures the notification is sent only after the deletion process finishes successfully.

Key changes:

  • Reordered deletion logic to call deleteWorkflowData before creating the notification event
  • Removed isDeletionInitialized method and all references as it's no longer needed for the new flow
  • Updated tests to mock deleteWorkflowData instead of isDeletionInitialized

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
DeleteWorkflowJobEventProcessor.java Moved deleteWorkflowData call before notification creation to ensure deletion completes first
MaestroWorkflowDeletionDao.java Removed obsolete isDeletionInitialized method no longer needed with the new flow
DeleteWorkflowJobEventProcessorTest.java Updated test mocks to stub deleteWorkflowData instead of removed isDeletionInitialized method
MaestroWorkflowDeletionDaoTest.java Removed test for deleted isDeletionInitialized method and cleaned up assertions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jun-he jun-he requested a review from Copilot December 4, 2025 22:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jun-he jun-he merged commit 7063de0 into main Dec 4, 2025
1 check passed
@jun-he jun-he deleted the jun/fix-delete-event branch December 4, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants