This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(ui): use own-built resizable drawer for EditSheet #6134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the third-party resizable drawer with a custom-built drawer component in the incident and case edit sheets, adds persistent width storage and resize handles, and introduces Playwright tests for drawer functionality.
- Swap out
VResizeDrawerforv-navigation-drawerwith custom resize handles inEditSheet.vuefor incidents and cases. - Store drawer width in
localStorage, add mouse event listeners to handle resizing. - Add Playwright E2E tests to verify the drawer opens, can be edited, and closes correctly.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/static/e2e/drawer-functionality.spec.ts | New E2E tests for opening, editing, and closing drawers |
| src/dispatch/static/dispatch/src/main.js | Removed unused VResizeDrawer import and registration |
| src/dispatch/static/dispatch/src/incident/EditSheet.vue | Implemented custom resizable drawer for incidents |
| src/dispatch/static/dispatch/src/case/EditSheet.vue | Implemented custom resizable drawer for cases |
| src/dispatch/static/dispatch/package.json | Removed @wdns/vuetify-resize-drawer dependency |
Files not reviewed (1)
- src/dispatch/static/dispatch/package-lock.json: Language not supported
aliciamatsumoto
approved these changes
Jul 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the third-party resizable drawer with a custom-built drawer component in the incident and case edit sheets, adds persistent width storage and resize handles, and introduces Playwright tests for drawer functionality.
VResizeDrawerforv-navigation-drawerwith custom resize handles inEditSheet.vuefor incidents and cases.localStorage, add mouse event listeners to handle resizing.Screen capture
sliding_handle_drawer.mov