This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Fix(ai): Return raw response if error decoding JSON #6104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JSON decoding error handling in generate_case_signal_summary to return the raw plugin response instead of raising an exception, and adjusts the log message to include the decoding error.
- Change error handling for
json.JSONDecodeErrorto return raw response - Update warning message to include the exception detail
Comments suppressed due to low confidence (1)
src/dispatch/ai/service.py:308
- Add a unit test to cover the JSON decoding error path and verify that the raw response is returned as expected.
return {"Summary": response}
aaronherman
approved these changes
Jul 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JSON decoding error handling in
generate_case_signal_summaryto return the raw plugin response instead of raising an exception, and adjusts the log message to include the decoding error.