This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(genai): record genai error in logs #6103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds logging for errors encountered during GenAI analysis and preserves existing fallback behavior.
- Captures the
GenAIExceptionaseinstead of a bare except. - Logs a warning with the case ID and error message when GenAI analysis fails.
- Returns the original fallback summary and metadata blocks unchanged.
Comments suppressed due to low confidence (1)
src/dispatch/plugins/dispatch_slack/case/messages.py:391
- There’s no existing test for the
GenAIExceptionpath. Add a unit test that mocksai_service.generate_case_signal_summaryto raiseGenAIExceptionand asserts the warning log is emitted and the fallback summary is returned.
except GenAIException as e:
aaronherman
approved these changes
Jul 1, 2025
aliciamatsumoto
approved these changes
Jul 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging for errors encountered during GenAI analysis and preserves existing fallback behavior.