Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@whitdog47
Copy link
Contributor

@whitdog47 whitdog47 commented Jun 25, 2025

This PR updates the tooltip activator templates by renaming the destructured binding from "props" to "tooltipProps" to ensure unique naming for tooltip properties.

  • Renames the tooltip property in DetailsTab.vue
  • Applies the same renaming in ClosedDialog.vue

@whitdog47 whitdog47 requested a review from Copilot June 25, 2025 04:06
@whitdog47 whitdog47 self-assigned this Jun 25, 2025
@whitdog47 whitdog47 added the bug Something isn't working label Jun 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the tooltip activator templates by renaming the destructured binding from "props" to "tooltipProps" to ensure unique naming for tooltip properties.

  • Renames the tooltip property in DetailsTab.vue
  • Applies the same renaming in ClosedDialog.vue

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/dispatch/static/dispatch/src/case/DetailsTab.vue Updated tooltip activator binding for uniqueness in destructuring
src/dispatch/static/dispatch/src/case/ClosedDialog.vue Consistently applied tooltip binding renaming for clarity
Comments suppressed due to low confidence (2)

src/dispatch/static/dispatch/src/case/DetailsTab.vue:40

  • Renaming the destructured 'props' to 'tooltipProps' improves readability and prevents potential naming conflicts. Ensure that all related bindings in this component use the new naming consistently.
                    <template #activator="{ props: tooltipProps }">

src/dispatch/static/dispatch/src/case/ClosedDialog.vue:27

  • The renaming to 'tooltipProps' aligns with the changes in other components. Verify consistent usage of the new alias in all tooltip bindings.
                          <template #activator="{ props: tooltipProps }">

@whitdog47 whitdog47 merged commit 9dbeb87 into main Jun 25, 2025
9 checks passed
@whitdog47 whitdog47 deleted the fix/tooltip-props-have-own-name branch June 25, 2025 04:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants