This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(email_templates): disallow creation for non admins #6089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restricts email template creation to users with the appropriate admin permission and updates the Jinja2 dependency.
- Enforce
SensitiveProjectActionPermissionon thecreate_email_templateendpoint - Bump Jinja2 from 3.1.5 to 3.1.6
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dispatch/email_templates/views.py | Added a PermissionsDependency to the POST route for creation |
| requirements-base.txt | Upgraded jinja2 from 3.1.5 to 3.1.6 |
Comments suppressed due to low confidence (1)
src/dispatch/email_templates/views.py:49
- Add tests to verify that non-admin users are denied access when calling the create_email_template endpoint and that admins can still create templates.
dependencies=[Depends(PermissionsDependency([SensitiveProjectActionPermission]))],
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts email template creation to users with the appropriate admin permission and updates the Jinja2 dependency.
SensitiveProjectActionPermissionon thecreate_email_templateendpoint