This repository was archived by the owner on Sep 3, 2025. It is now read-only.
feat(events): send slack reminder for Security Events with default title #6084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to send a Slack reminder with a default title for security events and updates a user-facing message to provide clearer guidance.
- Updates the query in the case_triage_reminder function to filter cases by title or status.
- Revises the case triage reminder string to include additional update instructions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dispatch/messaging/strings.py | Revised reminder message to include instructions for updating fields. |
| src/dispatch/case/scheduled.py | Updated case_triage_reminder logic with an OR query for filtering cases. |
whitdog47
approved these changes
Jun 24, 2025
Contributor
whitdog47
left a comment
whitdog47
left a comment
There was a problem hiding this comment.
There will also now be a "Stable" status. Do you want this reminder setup for that state too?
Contributor
Author
It currently will send for New status or "Security Event Triage" titles, regardless of their status, so it should be good now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
case_triage_reminderfunction, enhancements to query logic, and an update to a user-facing message for case triage reminders.Enhancements to query logic:
src/dispatch/case/scheduled.py: Updated thecase_triage_reminderfunction to use a more complex query with theor_condition, allowing cases to be filtered by either title ("Security Event Triage") or status (CaseStatus.new). This replaces the previous call toget_all_by_status.User-facing message update:
src/dispatch/messaging/strings.py: Enhanced theCASE_TRIAGE_REMINDER_DESCRIPTIONmessage to include instructions for updating the case title, priority, severity, and tags, providing clearer guidance to users.